Results of boolean logic are safe #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue in which we considered the result of a null-check on an exception unsafe, which is not accurate. The fix is slightly more involved than it would have been due to the discovery of another bug: auto-boxing and auto-unboxing is interpreted as method invocations along the lines of `Boolean.valueOf(bool)` and `Boolean.booleanValue()` respectively. I added safety-passthrough for such methods.
Generate changelog in
|
fawind
approved these changes
Apr 28, 2022
|
Released 4.118.0 |
This was referenced Apr 28, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 28, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.118.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Results of boolean logic are considered safe | palantir/gradle-baseline#2232 | ## 4.119.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | Add a configuration point for providing your own JDKs to all java requiring tasks. | palantir/gradle-baseline#2193 | ## 4.120.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix intellij gradle integration copyright configuration | palantir/gradle-baseline#2234 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 28, 2022
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue in which we considered the result of
a null-check on an exception unsafe, which is not accurate.
The fix is slightly more involved than it would have been due to
the discovery of another bug: auto-boxing and auto-unboxing is
interpreted as method invocations along the lines of
Boolean.valueOf(bool)andBoolean.booleanValue()respectively.I added safety-passthrough for such methods.
==COMMIT_MSG==
Results of boolean logic are considered safe
==COMMIT_MSG==