Add property to explicitly enable Error Prone #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
commented
Jan 14, 2022
| log.info("Disabling baseline-error-prone for {} due to {}", project, DISABLE_PROPERTY); | ||
| errorProneOptions.getEnabled().set(false); | ||
| } else { | ||
| if (project.hasProperty(ENABLE_PROPERTY)) { | ||
| errorProneOptions.getEnabled().set(true); |
There was a problem hiding this comment.
We can just rely on the plugin to have an appropriate default value here:
https://github.com/tbroyer/gradle-errorprone-plugin/blob/8d1f44dcef0ee68b5712ab1d319acfd2826db2a6/src/main/kotlin/net/ltgt/gradle/errorprone/ErrorProneOptions.kt#L24-L25
pkoenig10
force-pushed
the
pkoenig10/enableErrorProne
branch
from
66cbba3 to
3b5fbda
Compare
iamdanfox
reviewed
Jan 14, 2022
gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
Outdated
Show resolved
Hide resolved
pkoenig10
force-pushed
the
pkoenig10/enableErrorProne
branch
from
baa2c04 to
df3539d
Compare
|
@carterkozak @ferozco Any thoughts on this? |
|
Released 4.66.0 |
This was referenced Jan 26, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 26, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.66.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | Error Prone can be explicitly enabled using the `com.palantir.baseline-error-prone.disable=false` Gradle property. | palantir/gradle-baseline#2042 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 26, 2022
This was referenced Jan 26, 2022
Merged
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2010 (comment)
Before this PR
Error Prone is always disabled when running in IntelliJ.
After this PR
Users can explicitly enable Error Prone, even when running in IntelliJ, by setting the
com.palantir.baseline-error-prone.disable=falseGradle property.