Error-prone is enabled in idea for uniformity with CLI compilation #2405
Conversation
error-prone requires several javac options to access compiler innards, which have the side-effect of enabling immutables to function correctly. Given this spooky interaction and our migration toward jdk17 source, it's best to provide uniform behavior.
Generate changelog in
|
|
Should we just remove this logic? The whole point of adding it in the first place is to disable it in IntelliJ. If we're not doing that then it seems a bit unnecessary to keep this. Unless we think there are people that want to opt-in? |
|
@pkoenig10 I'm making a minimal change for now, the property itself predates our intellij logic, so I'm leaving that alone for the time being. Figure it's best to avoid behavior changes in edge cases outside of intellij as that's easier than verifying nobody has used the boolean value in unexpected ways. Medium term, I'd like to see how folks react to errorprone failures in the IDE before making larger changes, we may want to filter out certain checks from idea based on feedback (which would unfortunately bust caches) |
We have some usage here and there:
Might not be necessary anymore but probably lower lift to just leave it around. |
|
Released 4.176.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.174.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Allow projects which don't use jdk-15 to resolve latest nullaway | palantir/gradle-baseline#2400 | ## 4.175.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix GitHub issues navigation Idea config | palantir/gradle-baseline#2403 | ## 4.176.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Error-prone is enabled in idea for uniformity with CLI compilation | palantir/gradle-baseline#2405 | ## 4.177.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | baseline-immutables adds required exports to the java compiler for compatibility with jdk-17+ | palantir/gradle-baseline#2406 | ## 4.178.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Refaster compilation uses exports matching error-prone compilation | palantir/gradle-baseline#2407 | To enable or disable this check, please contact the maintainers of Excavator.
error-prone requires several javac options to access compiler innards, which have the side-effect of enabling immutables to function correctly. Given this spooky interaction and our migration toward jdk17 source, it's best to provide uniform behavior.
==COMMIT_MSG==
Error-prone is enabled in idea for uniformity with CLI compilation
==COMMIT_MSG==