-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer project modules on dependency resolution per default #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
approved these changes
Jan 24, 2022
Released 4.63.0 |
This was referenced Jan 24, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 24, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.63.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Prefer project modules on dependency resolution per default | palantir/gradle-baseline#2056 | ## 4.64.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Use lazy task initialization for the `compileRefaster` task for improved performance when it is not needed. | palantir/gradle-baseline#2052 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 24, 2022
This was referenced Jan 24, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Every so often we run into support issues due to Gradle's version ordering semantics not being strictly compliant with our sls-version ordering.
E.g. based on the sls-spec,
1.264.0 < 1.264.0-90-g2f01179
holds true but according to Gradle's version ordering, the opposite is true,1.264.0-90-g2f01179 < 1.264.0
.Using its default resolution strategy, Gradle will try to substitute artifacts of local projects. However this can fail when the version ordering does not align because according to Gradle's version ordering, the module is relying on a version from the future.
As a result, Gradle fails on dependency resolution which errors such as:
After this PR
Prefer project modules that are part of this build over external modules on dependency resolution per default (docs).
This avoids the above conflict by always choosing the local project module on conflict.
==COMMIT_MSG==
Prefer project modules on dependency resolution per default
==COMMIT_MSG==
Possible downsides?