Javadoc tasks supporty BaselineModuleJvmArgs #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unblocks the error-prone 2.11 upgrade.
Generate changelog in
|
fawind
reviewed
Mar 28, 2022
| if (!exportValues.isEmpty()) { | ||
| coreOptions | ||
| // options are automatically prefixed with '-' internally | ||
| .addMultilineStringsOption("-add-exports") |
There was a problem hiding this comment.
Was wondering why we can't use collectClasspathArgs here which does a very similar colelction of the export and open args. Is it because of the -- vs - distinction?
There was a problem hiding this comment.
Sort of, add-exports only occurs once, and the values are collected on the right-hand-side.
fawind
approved these changes
Mar 28, 2022
|
Released 4.81.0 |
This was referenced Mar 28, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Mar 28, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.80.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Compilation supports add-exports/add-opens with toolchains | palantir/gradle-baseline#2136 | ## 4.81.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Javadoc tasks supporty BaselineModuleJvmArgs | palantir/gradle-baseline#2137 | ## 4.82.0 _Automated release, no documented user facing changes_ To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks the error-prone 2.11 upgrade.
==COMMIT_MSG==
Javadoc tasks supporty BaselineModuleJvmArgs
==COMMIT_MSG==