Suggest putting jupiter on runtime only #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
|
Go away stalebot! Friendly ping @iamdanfox and @xRuiAlves – this one needs your approval. |
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jan 12, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.57.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Upon missing jupiter on classpath, suggest putting it on runtime rather than implementation to avoid making checkUnusedDependenciesTest fail in return. | palantir/gradle-baseline#2021 | | Fix | Refine FilterOutputStreamSlowMultibyteWrite findings<br><br>Avoid warning FilterOutputStreamSlowMultibyteWrite when intermediate<br>type overrides both single and multibyte write methods. | palantir/gradle-baseline#2031 | | Improvement | Ban AfterburnerModule to reduce JDK-17 risk | palantir/gradle-baseline#2032 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jan 12, 2022
This was referenced Jan 12, 2022
Merged
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
checkUnusedDependenciesTest fails complaining org.junit.jupiter:junit-jupiter is unused and should be replaced by org.junit.jupiter:junit-jupiter-api. If one does that, checkJUnitDependencies fails and tells to put it back.
With this PR, a better solution is proposed in the error.
After this PR
==COMMIT_MSG==
Suggest putting jupiter on runtime only in error
==COMMIT_MSG==
Possible downsides?