baseline-java-versions uses library presets for projects using shadow-jar #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
reviewed
Mar 8, 2022
| // 'nebula.maven-publish' and 'com.github.johnrengelman.shadow' create publications lazily which cause | ||
| // inconsistencies based on ordering. | ||
| private static final ImmutableSet<String> LIBRARY_PLUGINS = | ||
| ImmutableSet.of("nebula.maven-publish", "com.github.johnrengelman.shadow"); |
There was a problem hiding this comment.
Is it actually the johnrengelman shadow or is it our gradle-shadow-jar which does this?
There was a problem hiding this comment.
Hmm, our one doesn't create publications - I'd be surprised if the johnrengelman did as well, as you have normally have to fiddle about with publications when using it.
There was a problem hiding this comment.
You're right, I think this is on us due to ShadowJarPlugin ensureShadowJarIsOnlyArtifactOnJavaConfigurations + dependOnJarTaskInOrderToTriggerTasksAddingManifestAttributes
|
👍 |
carterkozak
force-pushed
the
ckozak/special_case_shadowjar
branch
from
7eb7fd8 to
f8164bd
Compare
|
Released 4.75.0 |
This was referenced Mar 8, 2022
Merged
This was referenced Mar 8, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Mar 15, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.75.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Finalize java-versions extension values on read to prevent changes due to interactions from other plugins | palantir/gradle-baseline#2107 | | Improvement | baseline-java-versions uses library presets for projects using shadow-jar to prevent resolution/mutation ordering failures | palantir/gradle-baseline#2108 | To enable or disable this check, please contact the maintainers of Excavator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
baseline-java-versions uses library presets for projects using shadow-jar to prevent resolution/mutation ordering failures
==COMMIT_MSG==