improvement: Remove java 8 errorprone support #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What prompted this? |
|
I originally wrote this code and since we have increased source compatibility across the board to 11 I don't think it's no longer necessary. Thought of this as a bit of a cleanup |
|
oof it looks like java 9 support broke around 4.59.0 based on palantir/jvm-diagnostics#96 |
|
Looks like as of 2.11 error-prone requires java 11 google/error-prone#2730 |
carterkozak
approved these changes
Feb 4, 2022
This was referenced Feb 7, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Feb 7, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.68.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Remove support for running errorprone witth java 8 target compatibility | palantir/gradle-baseline#2061 | | Improvement | `StrictUnusedVariable` no longer flags parameters of default methods. | palantir/gradle-baseline#2070 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Feb 7, 2022
This was referenced Feb 7, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
Remove support for running errorprone witth java 8 target compatibility
==COMMIT_MSG==
Possible downsides?