-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix class hierarchy safe-logging error message agreement #2295
Conversation
Previously the safety referenced in the message did not agree with the failure.
Generate changelog in
|
@@ -1768,7 +1768,8 @@ public void testSubclassWithLenientSafety() { | |||
"import com.palantir.logsafe.*;", | |||
"class Test {", | |||
" @Unsafe interface UnsafeClass {}", | |||
" // BUG: Diagnostic contains: Dangerous type: annotated 'SAFE' but ancestors declare 'SAFE'.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently I didn't read this very well and copy/pasted :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, also slipped through review 🙈
Released 4.142.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.142.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix class hierarchy safe-logging error message agreement | palantir/gradle-baseline#2295 | To enable or disable this check, please contact the maintainers of Excavator.
Previously the safety referenced in the message did not agree
with the failure.
==COMMIT_MSG==
Fix class hierarchy safe-logging error message agreement
==COMMIT_MSG==