more Classes constants #2330
Merged
more Classes constants #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few more core classesPreview: documentation | landing | table |
fix testPreview: documentation | landing | table |
llorca
reviewed
Mar 29, 2018
packages/core/src/common/classes.ts
Outdated
| export const ELEVATION_1 = "pt-elevation-1"; | ||
| export const ELEVATION_2 = "pt-elevation-2"; | ||
| export const ELEVATION_3 = "pt-elevation-3"; | ||
| export const ELEVATION_4 = "pt-elevation-4"; |
There was a problem hiding this comment.
maybe we could have an elevationClass() function as well for safety
llorca
approved these changes
Mar 29, 2018
elevationClassPreview: documentation | landing | table |
use elevationClasses in cardPreview: documentation | landing | table |
EditableText classes, alph modifiers listPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2325
Add more
Classesconstants in core and datetime.Ensure we're using
Classesconstants everywhere.