customize CSS namespace #2325
Merged
customize CSS namespace #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorca
reviewed
Mar 27, 2018
| @@ -4,6 +4,9 @@ | |||
| @import "colors"; | |||
| @import "mixins"; | |||
|
|
|||
| $pt-namespace: "pt" !default; | |||
There was a problem hiding this comment.
why not one var like $ns: "pt" !default or $namespace: "pt" !default or $blueprint-namespace: "pt" !default?
use parent constant to derive child classesPreview: documentation | landing | table |
jkillian
reviewed
Mar 28, 2018
packages/core/src/common/classes.ts
Outdated
| @@ -7,207 +7,239 @@ | |||
| import { Alignment } from "./alignment"; | |||
| import { Intent } from "./intent"; | |||
|
|
|||
| const NS = "bp3"; | |||
There was a problem hiding this comment.
this namespace is bp3 but the one above is pt?
There was a problem hiding this comment.
yeah oops shhhhhh
replace `@ns` in compile-docs-dataPreview: documentation | landing | table |
|
gonna pull out some changes from this PR into separate ones to shrink the diff. |
Merged
themadcreator
approved these changes
Apr 3, 2018
Merge branch 'develop' of github.com:palantir/blueprint into gg/custom-namespacePreview: documentation | landing | table |
added 2 commits
April 3, 2018 12:17
only one `$ns` variablePreview: documentation | landing | table |
bring back env variable, namespace modifiersPreview: documentation | landing | table |
add Classes docs pagePreview: documentation | landing | table |
outstanding pt- namespace referencesPreview: documentation | landing | table |
This was referenced Apr 19, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support customizing the
pt-namespace on all classes.new
$pt-namespace(aliased as$nsfor brevity) Sass variable determines prefix for all generated CSS classes.use environment variable
process.env.BLUEPRINT_NAMESPACEto customize prefix in JSclasses.tsconstants files.docs CSS examples can safely use
#{$ns}in modifier lists and it will be replaced at runtime.TODO
Classes) strings in JS code