Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editable text classes #2413

Merged
merged 3 commits into from
Apr 20, 2018
Merged

fix editable text classes #2413

merged 3 commits into from
Apr 20, 2018

Conversation

giladgray
Copy link
Contributor

Changed the Classes constants in #2325 but didn't update CSS

@giladgray giladgray requested a review from llorca April 20, 2018 02:25
@blueprint-bot
Copy link

fix editable text classes

Preview: documentation | landing | table

Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it's missing placeholder styles
image

and something still looks wrong on focus
image

@blueprint-bot
Copy link

fix CSS classes, show placeholder when editing

Preview: documentation | landing | table

Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants