[core] fix(IconProps): widen type of HTML attributes #6283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fix a regression introduced by #6235 where consumers' usage of HTML attribute props on
<Icon>
stopped compiling successfully due to the more specificReact.HTMLAttributes<T>
type. This caused compilation errors such as:The fix in this case is to widen the type of the element param in
React.HTMLAttributes<T>
which was inadvertently narrowed in #6235. Turns out thatHTMLElement
is really just an alias forElement
(it adds no extra properties), so we were working with a pretty basic type in the first place.Reviewers should focus on:
Fixes the regression. I verified this in consumer code by editing Blueprint's
.d.ts
files in node_modules.