Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] feat: support Locale object in props #6406

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Sep 25, 2023

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • feat(DatePicker3, DateInput3, DateRangePicker3, DateRangeInput3): widen type of locale prop to allow statically-imported date-fns Locale objects

Reviewers should focus on:

No regressions, test suite coverage

Screenshot

image

@adidahiya
Copy link
Contributor Author

update tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix compile, docs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit de0b91e into develop Sep 25, 2023
@adidahiya adidahiya deleted the ad/fix-date-fns-locale-import branch September 25, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant