[datetime2] feat(DateRangeInput3): simpler formatting & parsing API #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[datetime2] fix(DateRangeInput3): support 'locale' prop correctlyBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
[datetime2] fix(DateInput3): forward locale to DatePicker3 correctlyBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix DateRangeInput3 locale testBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to the same change for DateInput3: #6398
Checklist
Changes proposed in this pull request:
DateRangeInput3):formatDateandparseDateprops are now optional. The component will use a date-fns formatter & parser with a format string inferred from the time precision setting.DateRangeInput3): newdateFnsFormatprop allows users to easily customize the date formatter, parser, and input placeholder without having to write custom formatting & parsing functionsDateInput3): forwardlocaletoDatePicker3correctly so that month & year dropdown labels are localizedReviewers should focus on:
Test cases, no regressions in example
Screenshot