Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drawer not closing on first render #6606

Conversation

joaodantas91
Copy link

Changes proposed in this pull request:

Added a setTimeout around overlayWillOpen, to wait until this.containerElement can be updated

Reviewers should focus on:

This PR addresses the review left on #6399

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @joaodantas91! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

@joaodantas91 this PR is failing unit tests & formatting checks, I'll convert it to a draft for now. Happy to review once those checks are resolved, or if you have other feedback about the implementation.

@adidahiya
Copy link
Contributor

Closing as this stale PR has not been updated for over a month. Ping if you want to re-open.

@adidahiya adidahiya closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants