Excavator: Format Java files #1285

svc-excavator-bot · 2019-10-23T09:20:48Z

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/format check.

To enable or disable this check, please contact the maintainers of Excavator.

dansanduleac · 2019-10-23T09:23:14Z

client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfigurations.java

+                .fallbackToCommonNameVerification(
+                        config.fallbackToCommonNameVerification().orElse(DEFAULT_FALLBACK_TO_COMMON_NAME_VERIFICATION))
+                .proxy(config.proxy().map(ClientConfigurations::createProxySelector).orElseGet(ProxySelector
+                        ::getDefault))


so.. this is the kind of sadness enabled by the quick hack in palantir/palantir-java-format#44

iamdanfox · 2019-10-23T09:58:45Z

...t-config/src/test/java/com/palantir/conjure/java/client/config/ClientConfigurationsTest.java

+                        .failedUrlCooldown(Duration.ofMillis(0))
+                        .build())
+                .isInstanceOf(IllegalArgumentException.class)
+                .hasMessage("If nodeSelectionStrategy is ROUND_ROBIN then failedUrlCooldown must be positive");


this is much nicer, exactly how I would have formatted it myself!

conjure-java-client-verifier/src/test/java/com/palantir/verification/Cases.java

iamdanfox · 2019-10-23T10:00:33Z

...re-java-client-verifier/src/test/java/com/palantir/verification/SingleParamServicesTest.java

-                                service,
-                                index,
-                                objectMapper.readValue(jsonString, cls));
+                        method.invoke(service, index, objectMapper.readValue(jsonString, cls));


iamdanfox · 2019-10-23T10:06:40Z

okhttp-clients/src/test/java/com/palantir/conjure/java/okhttp/TestBase.java

-                .protocol(Protocol.HTTP_1_1)
-                .code(code)
-                .message("unused")
-                .build();


@dansanduleac thoughts on some kind of heuristic that detects over 4 dot method invocations and doesn't try to squish them onto one line?

dansanduleac · 2019-11-12T20:24:05Z

keystores/src/main/java/com/palantir/conjure/java/config/ssl/SslSocketFactories.java

-                    config.keyStoreType(),
-                    config.keyStoreKeyAlias()).getKeyManagers();
+                            config.keyStorePath().get(), config.keyStorePassword()
+                                    .get(), config.keyStoreType(), config.keyStoreKeyAlias())


this is quite bad now in 0.3.1

dansanduleac · 2019-11-12T20:26:44Z

...t-config/src/test/java/com/palantir/conjure/java/client/config/ClientConfigurationsTest.java

@@ -71,7 +71,8 @@ public void testFromParameters_fillsInDefaults() {
        ClientConfiguration actual = ClientConfigurations.of(uris, sslFactory, trustManager);

        assertThat(actual.sslSocketFactory()).isInstanceOf(KeepAliveSslSocketFactory.class);
-        assertThat(((KeepAliveSslSocketFactory) actual.sslSocketFactory()).getDelegate()).isEqualTo(sslFactory);
+        assertThat(((KeepAliveSslSocketFactory) actual.sslSocketFactory()).getDelegate())
+                .isEqualTo(sslFactory);


@iamdanfox @ferozco 0.3.1 made a lot of the fluent assertions line break.
I don't think that's necessarily bad though, it makes it a lot more obvious that there is a method call without having to look all the way to the right for it.

I think the additional break is fine

conjure-java-client-verifier/src/test/java/com/palantir/verification/Cases.java

stale · 2019-11-29T04:00:44Z

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

dansanduleac · 2019-12-10T12:07:57Z

...nt/src/main/java/com/palantir/conjure/java/client/jaxrs/AbstractFeignJaxRsClientBuilder.java

-                                                                new JacksonDecoder(objectMapper))))))));
+        return new NeverReturnNullDecoder(new Java8OptionalAwareDecoder(new GuavaOptionalAwareDecoder(
+                new EmptyContainerDecoder(objectMapper, new InputStreamDelegateDecoder(new TextDelegateDecoder(
+                        new CborDelegateDecoder(cborObjectMapper, new JacksonDecoder(objectMapper))))))));


unclear if this is better... but I think it's acceptable

dansanduleac · 2019-12-10T12:24:46Z

...xrs-client/src/test/java/com/palantir/conjure/java/client/jaxrs/JaxRsClientFailoverTest.java

-                        .from(createTestConfig("http://foo-bar-bogus-host.unresolvable:80",
-                                "http://localhost:" + failoverTestCase.server1.getPort()))
+                        .from(createTestConfig("http://foo-bar-bogus-host.unresolvable:80", "http://localhost:"
+                                + failoverTestCase.server1.getPort()))


this is not good but I have an idea of how to fix it

palantir/palantir-java-format#104

stale · 2019-12-24T12:39:16Z

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

svc-excavator-bot added no changelog merge when ready labels Oct 23, 2019

policy-bot bot requested a review from iamdanfox October 23, 2019 09:20

dansanduleac reviewed Oct 23, 2019

View reviewed changes

iamdanfox reviewed Oct 23, 2019

View reviewed changes

conjure-java-client-verifier/src/test/java/com/palantir/verification/Cases.java Show resolved Hide resolved

iamdanfox reviewed Oct 23, 2019

View reviewed changes

svc-excavator-bot force-pushed the roomba/format branch 3 times, most recently from 1800f6e to 520a55f Compare October 29, 2019 19:48

svc-excavator-bot force-pushed the roomba/format branch from 520a55f to 26986e9 Compare October 30, 2019 19:54

Excavator: Format Java files

6031bfd

svc-excavator-bot force-pushed the roomba/format branch from 26986e9 to 6031bfd Compare November 1, 2019 15:26

changes with 0.3.1

36e4377

dansanduleac reviewed Nov 12, 2019

View reviewed changes

Delete 999_palantir.txt

a684e6b

dansanduleac reviewed Nov 12, 2019

View reviewed changes

conjure-java-client-verifier/src/test/java/com/palantir/verification/Cases.java Outdated Show resolved Hide resolved

dansanduleac added 2 commits November 13, 2019 10:41

0.3.2

cf4139c

Merge remote-tracking branch 'origin/roomba/format' into roomba/format

915552d

stale bot added the stale label Nov 29, 2019

dansanduleac added 3 commits December 4, 2019 17:06

changes after using palantir/palantir-java-format#94

b5d6f00

0.3.4

5b46716

fix up ImmutableMap.of

c1e7a8e

stale bot removed the stale label Dec 4, 2019

dansanduleac added 2 commits December 4, 2019 19:25

Merge remote-tracking branch 'origin/develop' into roomba/format

4c5bb50

extra formatting

eaf101b

dansanduleac closed this Dec 10, 2019

dansanduleac reopened this Dec 10, 2019

dansanduleac added 2 commits December 10, 2019 12:05

Merge remote-tracking branch 'origin/develop' into roomba/format

045aaad

Reformat

56e666a

dansanduleac reviewed Dec 10, 2019

View reviewed changes

stale bot added the stale label Dec 24, 2019

stale bot closed this Dec 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Excavator: Format Java files #1285

Excavator: Format Java files #1285

svc-excavator-bot commented Oct 23, 2019

dansanduleac Oct 23, 2019

iamdanfox Oct 23, 2019

iamdanfox Oct 23, 2019

iamdanfox Oct 23, 2019

dansanduleac Nov 12, 2019

dansanduleac Nov 12, 2019 •

edited

Loading

ferozco Nov 15, 2019

stale bot commented Nov 29, 2019

dansanduleac Dec 10, 2019

dansanduleac Dec 10, 2019

dansanduleac Dec 10, 2019

stale bot commented Dec 24, 2019

Excavator: Format Java files #1285

Excavator: Format Java files #1285

Conversation

svc-excavator-bot commented Oct 23, 2019

excavator is a bot for automating changes across repositories.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dansanduleac Nov 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Nov 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Dec 24, 2019

dansanduleac Nov 12, 2019 •

edited

Loading