Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryingChannel does not propagate cancelation #311

Closed
carterkozak opened this issue Feb 11, 2020 · 1 comment
Closed

RetryingChannel does not propagate cancelation #311

carterkozak opened this issue Feb 11, 2020 · 1 comment

Comments

@carterkozak
Copy link
Contributor

What happened?

When futures are canceled, the underlying request is not.

What did you want to happen?

Cancellation should make its way to the actual http client.
carterkozak added a commit that referenced this issue Feb 18, 2020
@carterkozak
fix #311: RetryingChannel propagates cancelation
86a2c1b 
Generally safer by using existing utility functionality to chain
futures instead of reimplementing async-transformation via
callbacks.
carterkozak added a commit that referenced this issue Feb 18, 2020
@carterkozak
fix #311: RetryingChannel propagates cancelation (#368)
fbdb33f 
* fix #311: RetryingChannel propagates cancelation

Generally safer by using existing utility functionality to chain
futures instead of reimplementing async-transformation via
callbacks.
@carterkozak
Copy link
Contributor Author

Fixed by #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carterkozak