Fix off-by-one in RetryingChannel, use the configured number of retries #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Feb 18, 2020
| // TODO(dfox): include retry number in the request somehow | ||
| return delegate.execute(endpoint, request); | ||
| }; | ||
| FutureCallback<Response> retryer = new RetryingCallback(callSupplier, future); | ||
| Futures.addCallback(callSupplier.apply(0), retryer, DIRECT_EXECUTOR); | ||
|
|
||
| DialogueFutures.addDirectCallback(callSupplier.apply(0), retryer); | ||
| return future; | ||
| } | ||
|
|
||
| private final class RetryingCallback implements FutureCallback<Response> { | ||
| private final AtomicInteger failures = new AtomicInteger(0); |
There was a problem hiding this comment.
This should be an int given that retries are sequenced we can rely on the happens-before relationship.
There was a problem hiding this comment.
do you want to make that change as part of this PR?
There was a problem hiding this comment.
I'll add it to a an improvement on top of this PR, might be best if you'd like to review that in isolation :-]
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Fix off-by-one in RetryingChannel, use the configured number of retries
==COMMIT_MSG==
Possible downsides?
Doesn't support the configured backoff interval yet.