Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #101

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 19, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.32.0

Type Description Link
Fix Checkstyle no longer complains about single-line javadoc produced by palantir-java-format. palantir/gradle-baseline#1051
Improvement PreferAssertj disallows assert statements in test code.

Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the assert keyword should never be used, preferring preconditions. This way production environments cannot reach code paths that are impossible to test.
palantir/gradle-baseline#1052

2.33.0

Type Description Link
Improvement Implement Slf4jThrowable check to ensure throwable args are logged last palantir/gradle-baseline#1054

2.34.0

Type Description Link
Improvement Adds an ErrorProne rule, JooqResultStreamLeak, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block. palantir/gradle-baseline#1055

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from b0e1f7b to 36cf1e4 Compare November 19, 2019 22:54
@SerialVelocity SerialVelocity merged commit 4c2cfa2 into develop Nov 20, 2019
@SerialVelocity SerialVelocity deleted the roomba/latest-baseline-oss branch November 20, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants