-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreferAssertj disallows assert
statements in test code.
#1052
Merged
bulldozer-bot
merged 3 commits into
develop
from
ckozak/PreferAssertj_asserts_in_test_code
Nov 18, 2019
Merged
PreferAssertj disallows assert
statements in test code.
#1052
bulldozer-bot
merged 3 commits into
develop
from
ckozak/PreferAssertj_asserts_in_test_code
Nov 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ferozco
approved these changes
Nov 18, 2019
bulldozer-bot
bot
deleted the
ckozak/PreferAssertj_asserts_in_test_code
branch
November 18, 2019 19:00
Released 2.32.0 |
This was referenced Nov 19, 2019
This was referenced Nov 19, 2019
This was referenced Nov 29, 2019
This was referenced Dec 16, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
PreferAssertj disallows
assert
statements in test code.Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the
assert
keyword should never be used, preferring preconditions allowing production environments to avoid invoking code paths that are impossible to test.==COMMIT_MSG==