Fix #1159: StrictUnusedVariable respects UnusedVariable suppression (#…

…1160) StrictUnusedVariable respects UnusedVariable suppression
palantir · Jan 10, 2020 · 8ecf71f · 8ecf71f
1 parent c4fb0df
commit 8ecf71f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/...line-error-prone/src/main/java/com/palantir/baseline/errorprone/StrictUnusedVariable.java b/...line-error-prone/src/main/java/com/palantir/baseline/errorprone/StrictUnusedVariable.java
@@ -106,7 +106,7 @@
 @AutoService(BugChecker.class)
 @BugPattern(
         name = "StrictUnusedVariable",
-        altNames = {"unused", "StrictUnusedVariable"},
+        altNames = {"unused", "UnusedVariable"},
         link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
         linkType = BugPattern.LinkType.CUSTOM,
         summary = "Unused.",

diff --git a/...-error-prone/src/test/java/com/palantir/baseline/errorprone/StrictUnusedVariableTest.java b/...-error-prone/src/test/java/com/palantir/baseline/errorprone/StrictUnusedVariableTest.java
@@ -215,4 +215,19 @@ public void fixes_previously_suppressed_variables() {
                         "}"
                 ).doTest(TestMode.TEXT_MATCH);
     }
+
+    @Test
+    public void testSuppression() {
+        refactoringTestHelper
+                .addInputLines(
+                        "Test.java",
+                        "class Test {",
+                        "  public static void a(@SuppressWarnings(\"StrictUnusedVariable\") int val) {}",
+                        "  public static void b(@SuppressWarnings(\"UnusedVariable\") int val) {}",
+                        "  public static void c(@SuppressWarnings(\"unused\") int val) {}",
+                        "  public static void d(int _val) {}",
+                        "}")
+                .expectUnchanged()
+                .doTest(TestMode.TEXT_MATCH);
+    }
 }
diff --git a/changelog/@unreleased/pr-1160.v2.yml b/changelog/@unreleased/pr-1160.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: StrictUnusedVariable respects UnusedVariable suppression
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/1160