-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1159: StrictUnusedVariable respects UnusedVariable suppression #1160
Merged
bulldozer-bot
merged 2 commits into
develop
from
ckozak/StrictUnusedVariable_suppressions
Jan 10, 2020
Merged
Fix #1159: StrictUnusedVariable respects UnusedVariable suppression #1160
bulldozer-bot
merged 2 commits into
develop
from
ckozak/StrictUnusedVariable_suppressions
Jan 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Jan 10, 2020
@@ -106,7 +106,7 @@ | |||
@AutoService(BugChecker.class) | |||
@BugPattern( | |||
name = "StrictUnusedVariable", | |||
altNames = {"unused", "StrictUnusedVariable"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unnecessary to duplicate the name
.
dansanduleac
approved these changes
Jan 10, 2020
bulldozer-bot
bot
deleted the
ckozak/StrictUnusedVariable_suppressions
branch
January 10, 2020 15:03
Released 2.48.3 |
This was referenced Jan 10, 2020
This was referenced Jan 11, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR
==COMMIT_MSG==
StrictUnusedVariable respects UnusedVariable suppression
==COMMIT_MSG==