Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refaster rule to remove unnecessary supplier creation (#1059)" #1063

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

carterkozak
Copy link
Contributor

The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).

This reverts commit 686d71f.

After this PR

==COMMIT_MSG==
Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).
==COMMIT_MSG==

The refaster rule breaks the common pattern:
`Suppliers.memoize(supplier::get)`.

This reverts commit 686d71f.
@changelog-app
Copy link

changelog-app bot commented Nov 21, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah unlucky - spotted in a large internal repo by any chance?

@bulldozer-bot bulldozer-bot bot merged commit a6dca4a into develop Nov 21, 2019
@bulldozer-bot bulldozer-bot bot deleted the ckozak/revert_supplier_refaster branch November 21, 2019 12:47
@svc-autorelease
Copy link
Collaborator

Released 2.35.1

This was referenced Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants