Excavator: Upgrades Baseline to the latest version #1066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Nov 25, 2019
| ASTHelpers.isSameType(type, state.getTypeFromString("java.lang.String"), state)) | ||
| .map(ignored -> Stream.<String>of()) | ||
| .filter(type -> ASTHelpers.isSameType(type, state.getTypeFromString("java.lang.String"), state)) | ||
| .map(ignored -> Stream.empty()) |
There was a problem hiding this comment.
does adding a Stream.<String>empty() help here?
There was a problem hiding this comment.
What if we remove the refaster rule in favor of an error-prone rule? They're a lot more precise, and afaict cover all cases.
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
1f9ec85 to
25ab15d
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
25ab15d to
4072dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.35.0
2.35.1
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).2.35.2
2.36.0
StreamEmptywith error proneStreamOfEmptyto allow refactors to retain type arguments.2.37.0
AssertjPrimitiveComparisonfor primitive comparisonsPrefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
To enable or disable this check, please contact the maintainers of Excavator.