Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ThrowSpecificty and CatchSpecificity fixes by default #1098

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Disable ThrowSpecificty and CatchSpecificity fixes by default #1098

merged 2 commits into from
Dec 6, 2019

Conversation

carterkozak
Copy link
Contributor

We can reenable these once we have scala detection. Scala code
throws checked exceptions without declaring them.

Before this PR

Code which interacts with scala stops catching checked exceptions because they aren't declared.

After this PR

==COMMIT_MSG==
Disable ThrowSpecificty and CatchSpecificity fixes by default
==COMMIT_MSG==

Possible downsides?

Note: calling these out in the compiler logs until we implement scala detection.

@carterkozak
Disable ThrowSpecificty and CatchSpecificity fixes by default
f9c16be 
We can reenable these once we have scala detection. Scala code
throws checked exceptions without declaring them.
@carterkozak
Add generated changelog entries
5f51d80
@carterkozak carterkozak requested a review from iamdanfox December 6, 2019 13:57
@changelog-app
Copy link

changelog-app bot commented Dec 6, 2019 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Disable ThrowSpecificty and CatchSpecificity fixes by default

Check the box to generate changelog(s)

  • Generate changelog entry

iamdanfox
iamdanfox approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as these are both SUGGESTIONs at the moment, so shouldn't block anyone

@carterkozak
Copy link
Contributor Author

dozer?

@bulldozer-bot bulldozer-bot bot merged commit 9feb8e5 into develop Dec 6, 2019
@bulldozer-bot bulldozer-bot bot deleted the ckozak/disable_specificity_auto_fix branch December 6, 2019 15:30
@svc-autorelease
Copy link
Collaborator

Released 2.40.2

This was referenced Dec 6, 2019
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Dec 6, 2019
Merged
Merged
Closed
Merged
Merged
This was referenced Dec 16, 2019
Closed
Merged
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Jan 6, 2020
Merged
This was referenced Jan 16, 2020
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carterkozak @svc-autorelease @iamdanfox