Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #371

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Dec 3, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.38.0

Type Description Link
Improvement We now run error-prone 2.3.4, to benefit from smarter static analysis, and hopefully pick up the claimed performance Improvements:

> 40% speedup when run against Google's codebase with errors enabled.
palantir/gradle-baseline#1082

2.39.0

Type Description Link
Improvement Baseline now depends on mockito-errorprone to get Mockito error-prone checks. palantir/gradle-baseline#1085

2.40.0

Type Description Link
Improvement Error prone CatchSpecificity and ThrowSpecificity to avoid unnecessarily broad throwables.

Prefer more specific catch types than Exception and Throwable.
When methods are updated to throw new checked exceptions they expect
callers to handle failure types explicitly. Catching broad types defeats
the type system. By catching the most specific types possible we
leverage existing compiler functionality to detect unreachable code.
palantir/gradle-baseline#1074
Improvement For repos that opted into palantir-java-format, the arguments of SafeArg.of (when it's a last argument) are no longer unexpectedly split onto the next line. palantir/gradle-baseline#1075

2.40.1

Type Description Link
Fix The PreferJavaTimeOverload error-prone check is turned off as it produces noisy false positives relating to custom AssertJ utilities. palantir/gradle-baseline#1094

2.40.2

Type Description Link
Fix Disable ThrowSpecificty and CatchSpecificity fixes by default palantir/gradle-baseline#1098

2.41.0

No documented user facing changes

2.42.0

Type Description Link
Improvement Improve NonComparableStreamSort to validate that stream types implement comparable, as opposed to validating that casting to comparable does not cause a compiler error.

This commit reduces the severity to WARNING because it's
possible that the check will flag code that happens to work
today, but we strongly recommend against sorting streams of
a type that is not directly comparable without a custom
comparator because it is likely to break later due to lack
of enforcement by the type system.
palantir/gradle-baseline#1070
Improvement You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the -PerrorProneApply option.
palantir/gradle-baseline#1109
Fix Migrate baseline error-prone checks to use jdk13 compatible qualifiers palantir/gradle-baseline#1110

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 19dd094 to 66ad8a8 Compare December 10, 2019 23:23
@bulldozer-bot bulldozer-bot bot merged commit 745c88a into develop Dec 11, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch December 11, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants