-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-default errorprone fixes to be applied from the command line #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may apply specific error-prone refactors including those which are not enabled by default by providing a comma delimited list of check names to the `-PerrorProneApply` option. ```bash ./gradlew compileJava compileTestJava -PerrorProneApply=PreferAssertj ``` In an interal project we have used a similar flag to test refactors prior to rollout, and I have wished that it was available to help with Assertj rollout to avoid temporarily modifying gradle configurations.
Generate changelog in
|
iamdanfox
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hell yes
👍 |
This was referenced Dec 10, 2019
This was referenced Dec 10, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
In an internal project we have used a similar flag to test refactors
prior to rollout, and I have wished that it was available to help
with Assertj rollout to avoid temporarily modifying gradle
configurations.
After this PR
==COMMIT_MSG==
You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the
-PerrorProneApply
option.==COMMIT_MSG==