Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error-prone CompileTimeConstantViolatesLiskovSubstitution check #1559

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Add error-prone CompileTimeConstantViolatesLiskovSubstitution check #1559

merged 4 commits into from
Nov 25, 2020

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Add error-prone CompileTimeConstantViolatesLiskovSubstitution check
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Nov 23, 2020 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add error-prone CompileTimeConstantViolatesLiskovSubstitution check to require consistent application of the @CompileTimeConstant annotation.

Check the box to generate changelog(s)

  • Generate changelog entry

iamdanfox
iamdanfox reviewed Nov 23, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@iamdanfox
Copy link
Contributor

This is pretty fun! How much do you think it will tank compiler performance?

@carterkozak
Copy link
Contributor Author

I imagine it will be... measurable

@carterkozak carterkozak force-pushed the ckozak/CompileTimeConstantViolatesLiskovSubstitution branch from 3155d5d to 880925b Compare November 25, 2020 17:21
@carterkozak carterkozak mentioned this pull request Nov 25, 2020
Open
@bulldozer-bot bulldozer-bot bot merged commit dce9342 into develop Nov 25, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/CompileTimeConstantViolatesLiskovSubstitution branch November 25, 2020 18:15
@svc-autorelease
Copy link
Collaborator

Released 3.57.0

This was referenced Jun 22, 2021
Closed
Closed
Merged
Merged
Closed
Open
Merged
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Sep 15, 2021
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carterkozak @iamdanfox @svc-autorelease