Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IncubatingMethod check #1698

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Fix IncubatingMethod check #1698

merged 2 commits into from
Mar 29, 2021

Conversation

blacksmithgu
Copy link
Contributor

The check was non-functional; the test did not catch this since it was using the wrong @Test annotation. Fixed both issues.

@blacksmithgu
Fix IncubatingMethod check
a9de9d8 
The check was non-functional; the test did not catch this since it was
using the wrong `@Test` annotation.
@blacksmithgu
Add generated changelog entries
ca9518c
@changelog-app
Copy link

changelog-app bot commented Mar 29, 2021 •
edited by blacksmithgu
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix IncubatingMethod check

The check was non-functional; the test did not catch this since it was using the wrong @Test annotation. Fixed both issues.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind March 29, 2021 22:15
@bulldozer-bot bulldozer-bot bot merged commit eb786ea into develop Mar 29, 2021
@bulldozer-bot bulldozer-bot bot deleted the mbrenan/fix-incubating branch March 29, 2021 22:27
@svc-autorelease
Copy link
Collaborator

Released 3.75.1

This was referenced Jun 22, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Open
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@fawind fawind Awaiting requested review from fawind

@lycarter lycarter Awaiting requested review from lycarter

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blacksmithgu @svc-autorelease @carterkozak