Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IncubatingMethod check #1698

Merged
merged 2 commits into from
Mar 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public final class IncubatingMethod extends BugChecker

/** Matcher for the Incubating annotation, using the full qualified path. */
private static final Matcher<Tree> INCUBATING_MATCHER =
Matchers.hasAnnotation("com.palantir.conjure.java.lib.internal.Incubating");
Matchers.symbolHasAnnotation("com.palantir.conjure.java.lib.internal.Incubating");

@Override
public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
package com.palantir.baseline.errorprone;

import com.google.errorprone.CompilationTestHelper;
import org.junit.Test;
import org.junit.jupiter.api.Test;

public class IncubatingMethodTest {

Expand Down
8 changes: 8 additions & 0 deletions changelog/@unreleased/pr-1698.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
type: fix
fix:
description: |-
Fix IncubatingMethod check

The check was non-functional; the test did not catch this since it was using the wrong `@Test` annotation. Fixed both issues.
links:
- https://github.com/palantir/gradle-baseline/pull/1698