WIP Avoid new HashMap(int) #1771
Conversation
Generate changelog in
|
| + ".newHashMapWithExpectedSize which behaves as expected." | ||
| + "See" | ||
| + " https://github.com/palantir/gradle-baseline/blob/develop/docs/best-practices/java-coding-guidelines/readme.md#avoid-generics-clutter-where-possible" | ||
| + " for more information.") |
There was a problem hiding this comment.
we can move this message to the @BugPattern annotation summary, and it will be applied to the fix automatically when we don't call setMessage.
|
|
||
| SuggestedFix.Builder fixBuilder = SuggestedFix.builder(); | ||
| String newType = SuggestedFixes.qualifyType(state, fixBuilder, Maps.class.getName()); | ||
| String arg = tree.getArguments().isEmpty() |
There was a problem hiding this comment.
isEmpty should never evaluate to true for a constructor which takes an int argument -- we can either throw, or return Description.NO_MATCH. I tend to prefer the latter because we don't want to fail build sin cases that we haven't considered or don't understand.
|
|
||
| @AutoService(BugChecker.class) | ||
| @BugPattern( | ||
| name = "AvoidNewHashMapInt", |
There was a problem hiding this comment.
We should add this to the list of checks we automatically fix in BaselineErrorProneExtension, that way humans only have to review the change.
|
The changelog robot doesn't know how to push to forks, you'll need to add the changelog manually. Looks like the formatter needs to run as well, you can install the plugin for IntelliJ to update on save, https://plugins.jetbrains.com/plugin/13180-palantir-java-format, or run |
|
Closing in favor of branch on the main repo |
Before this PR
HashMap(int) has confusing behavior, use Maps.newHashMapWithExpectedSize(int) instead.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?