Feature/avoid hashmapint

[davidscottcohen]

Before this PR

new HashMap(int) is confusing

After this PR

==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Feature/avoid hashmapint

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

Recreated from #1771

[carterkozak]

lgtm, thanks!

[svc-autorelease]

Released 3.87.0

[pkoenig10]

The intention of this check conflicts with PreferCollectionConstructors. It's a bit confusing for devs to have JDK constructors preferred in some cases and Guava static factory methods preferred in others.

[carterkozak]

The intention of this check conflicts with PreferCollectionConstructors. It's confusing for devs to have JDK constructors preferred in some cases and Guava static factory methods preferred in others.

The hashmap(int) ctor itself is confusing, and it can cause serious problems when it's used expecting to insert the given number of elements when the value is used to size the hash table instead. That's why the PreferCollectionConstructors was implemented specifically to avoid flagging Maps.newHashMapWithExpectedSize(int)