Stops optimizing imports via palantir-java-formatter (#1089)

Stops optimizing imports via palantir-java-formatter
palantir · May 21, 2024 · 2fdb2c5 · 2fdb2c5
1 parent 9e6d8be
commit 2fdb2c5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 287 deletions.
diff --git a/changelog/@unreleased/pr-1089.v2.yml b/changelog/@unreleased/pr-1089.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Stops optimizing imports via palantir-java-formatter
+  links:
+  - https://github.com/palantir/palantir-java-format/pull/1089
diff --git a/...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java b/...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java
@@ -23,7 +23,6 @@
 import com.intellij.formatting.service.AsyncDocumentFormattingService;
 import com.intellij.formatting.service.AsyncFormattingRequest;
 import com.intellij.ide.highlighter.JavaFileType;
-import com.intellij.lang.ImportOptimizer;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.NlsSafe;
 import com.intellij.openapi.util.TextRange;
@@ -61,7 +60,7 @@ protected FormattingTask createFormattingTask(@NotNull AsyncFormattingRequest re
 
     @Override
     public @NotNull Set<Feature> getFeatures() {
-        return Set.of(Feature.FORMAT_FRAGMENTS, Feature.OPTIMIZE_IMPORTS);
+        return Set.of(Feature.FORMAT_FRAGMENTS);
     }
 
     @Override
@@ -70,14 +69,6 @@ public boolean canFormat(@NotNull PsiFile file) {
                 && PalantirJavaFormatSettings.getInstance(file.getProject()).isEnabled();
     }
 
-    @Override
-    public @NotNull Set<ImportOptimizer> getImportOptimizers(@NotNull PsiFile file) {
-        Project project = file.getProject();
-        PalantirJavaFormatSettings settings = PalantirJavaFormatSettings.getInstance(project);
-        Optional<FormatterService> formatter = formatterProvider.get(project, settings);
-        return Set.of(new PalantirJavaFormatImportOptimizer(formatter));
-    }
-
     private static final class PalantirJavaFormatFormattingTask implements FormattingTask {
         private final AsyncFormattingRequest request;
         private final Optional<FormatterService> formatterService;

diff --git a/...gin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatImportOptimizer.java b/...gin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatImportOptimizer.java
diff --git a/...src/test/java/com/palantir/javaformat/intellij/PalantirJavaFormatImportOptimizerTest.java b/...src/test/java/com/palantir/javaformat/intellij/PalantirJavaFormatImportOptimizerTest.java