Stops optimizing imports via palantir-java-formatter #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
reviewed
May 21, 2024
| @@ -95,6 +96,7 @@ public void tearDown() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled("Disabled the import optimization via palantir-java-format") | |||
There was a problem hiding this comment.
I'd delete these tests entirely.
CRogers
reviewed
May 21, 2024
| @@ -61,7 +61,7 @@ protected FormattingTask createFormattingTask(@NotNull AsyncFormattingRequest re | |||
|
|
|||
| @Override | |||
| public @NotNull Set<Feature> getFeatures() { | |||
| return Set.of(Feature.FORMAT_FRAGMENTS, Feature.OPTIMIZE_IMPORTS); | |||
| return Set.of(Feature.FORMAT_FRAGMENTS); | |||
There was a problem hiding this comment.
Should we return an empty set (or not override if it's set up like that) getImportOptimizers?
…rmat into cr/no-optimize
CRogers
approved these changes
May 21, 2024
|
Released 2.47.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Optimizing imports via palantir-java-format is slow.
Previously (before switching to the new api: #1078), we would use Intelij's import optimizations (see: old implementation weren't overriding the optimizeImports implementation)
After this PR
We stopped doing the import optimization via the
palantir-java-format. Now, it gets delegated to Intelij.==COMMIT_MSG==
Stops optimizing imports via palantir-java-formatter
==COMMIT_MSG==
Possible downsides?