Fix: Limit dotted chains for expressions starting with complex expression #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansanduleac
changed the title
|
Verified this makes positive changes in the conjure-java-runtime PR. |
ferozco
approved these changes
Nov 12, 2019
|
Released 0.3.2 |
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2019
When inlining a level's leading docs, check that no breaks were introduced more robustly. We already did some validation that the leading docs (1) don't contain forced breaks, and (2) can fit onto the current line However with the new logic added in #71, inner levels might decide to break even when the above two conditions are satisfied. We guard against this by checking whether the state after the inlining of leading docs has recorded new lines, which would be caused by an inner break being taken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
#70 didn't address all cases of method chains.
Specifically, cases where the dotted chain started with a constructor or a complex expression rather than a field / method call.
After this PR
==COMMIT_MSG==
Limit dotted chains for expressions starting with a complex expression such as a parenthesized expression or a constructor.
==COMMIT_MSG==
Possible downsides?