Add rid constructors

[k-simons]

• Add rid constructors for when you know the pieces of the identifier
• Add additional tests (caught no incorrect functionality 👍 )

---

This change is 

[bmoylan]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @k-simons)

---

rid/resource_identifier.go, line 50 at r1 (raw file):

}

func Of(service, instance, resourceType, locator string) (ResourceIdentifier, error) {

more idiomatic go would be New(...)

---

rid/resource_identifier.go, line 61 at r1 (raw file):

func (rid ResourceIdentifier) String() string {
	return strings.Join([]string{RidClass, rid.Service, rid.Instance, rid.Type, rid.Locator}, Separator)

I did the appends myself for performance reasons; strings.Join is quite slow.

---

rid/resource_identifier.go, line 82 at r1 (raw file):

// ParseRID parses a string into a 4-part resource identifier.
func ParseRID(s string) (ResourceIdentifier, error) {
	segments := strings.SplitN(s, ".", 5)

can use the Separator constant here

---

rid/resource_identifier.go, line 83 at r1 (raw file):

func ParseRID(s string) (ResourceIdentifier, error) {
	segments := strings.SplitN(s, ".", 5)
	if len(segments) != 5 || segments[0] != "ri" {

can use the RidClass constant here

[k-simons]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @bmoylan)

---

rid/resource_identifier.go, line 50 at r1 (raw file):

Previously, bmoylan (Brad Moylan) wrote…

more idiomatic go would be New(...)

Done.

---

rid/resource_identifier.go, line 61 at r1 (raw file):

Previously, bmoylan (Brad Moylan) wrote…

I did the appends myself for performance reasons; strings.Join is quite slow.

Done.

---

rid/resource_identifier.go, line 82 at r1 (raw file):

Previously, bmoylan (Brad Moylan) wrote…

can use the Separator constant here

Done.

---

rid/resource_identifier.go, line 83 at r1 (raw file):

Previously, bmoylan (Brad Moylan) wrote…

can use the RidClass constant here

Done.

[bmoylan]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @bmoylan)

[bmoylan]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[nmiyake]

---

rid/resource_identifier.go, line 38 at r2 (raw file):

const (
	RidClass  = "ri"

Is there a reason these constants need to be exported? Seems like they should be private.

Also, if exported, should be RIDClass.

[nmiyake]

---

rid/resource_identifier.go, line 42 at r2 (raw file):

)

func MustNew(service, instance, resourceType, locator string) ResourceIdentifier {

Where is MustNew intended to be used? I would prefer not to include this as part of the actual API (if there's a client/tests that want to do this, they can easily implement this on their end).

[nmiyake]

I see that this merged, but have some feedback that I think we should work through/address before cutting a release.

[k-simons]

@nmiyake will open a follow up to discuss

[k-simons]

#135