Don't export rid constants

[k-simons]

• Don't export rid constants

---

This change is 

[k-simons]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

---

rid/resource_identifier.go, line 42 at r1 (raw file):

)

func MustNew(service, instance, resourceType, locator string) ResourceIdentifier {

MustNew will be used by any client that has a static rid that will never change and will not throw an error. This is a common enough use case that I believe the rids package should provide a helper methods. Yes it could be implemented by every single client, but its the same reason https://github.com/palantir/pkg/blob/master/metrics/tag.go#L121 exists

[nmiyake]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @k-simons)

---

rid/resource_identifier.go, line 42 at r1 (raw file):

Previously, k-simons wrote…

MustNew will be used by any client that has a static rid that will never change and will not throw an error. This is a common enough use case that I believe the rids package should provide a helper methods. Yes it could be implemented by every single client, but its the same reason https://github.com/palantir/pkg/blob/master/metrics/tag.go#L121 exists

OK yup if instantiation of static RIDs is a common use case then that makes sense and I agree -- thanks for the clarification!

[nmiyake]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @k-simons)

[nmiyake]

Dismissed @k-simons from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved