fix[file-header]: fix enforce-trailing-newline (#4890)

palantir · Nov 10, 2019 · b5de3dd · b5de3dd
1 parent 8c2ac95
commit b5de3dd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/rules/fileHeaderRule.ts b/src/rules/fileHeaderRule.ts
@@ -244,9 +244,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         );
 
         const NEW_LINE_FOLLOWING_HEADER = /^.*((\r)?\n){2,}$/gm;
-        return (
-            entireComment !== undefined && NEW_LINE_FOLLOWING_HEADER.test(entireComment) !== null
-        );
+        return entireComment !== undefined && !NEW_LINE_FOLLOWING_HEADER.test(entireComment);
     }
 
     private getFileHeaderText(

diff --git a/test/rules/file-header/good-newline/test.ts.lint b/test/rules/file-header/good-newline/test.ts.lint
@@ -0,0 +1,3 @@
+/* Copyright 2019 */
+
+class Foo {}
diff --git a/test/rules/file-header/good-newline/tslint.json b/test/rules/file-header/good-newline/tslint.json
@@ -0,0 +1,10 @@
+{
+    "rules": {
+        "file-header": [
+            true,
+            "Copyright \\d{4}",
+            "Copyright 2019",
+            "enforce-trailing-newline"
+        ]
+    }
+}