Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix[file-header]: fix enforce-trailing-newline option #4890

Merged
merged 1 commit into from
Nov 10, 2019
Merged

fix[file-header]: fix enforce-trailing-newline option #4890

merged 1 commit into from
Nov 10, 2019

Conversation

tanmoyopenroot
Copy link
Contributor

PR checklist

Overview of change:

Remove null check from Regex test

CHANGELOG.md entry:

[bugfix] fix enforce-trailing-newline option in file-header rule

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, amusing find. Thank you!

@JoshuaKGoldberg JoshuaKGoldberg merged commit b5de3dd into palantir:master Nov 10, 2019
This was referenced Mar 18, 2020
Closed
Closed
Closed
This was referenced Mar 14, 2021
Merged
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file-header rule option "enforce-trailing-newline" is always violated
2 participants
@tanmoyopenroot @JoshuaKGoldberg