-
Notifications
You must be signed in to change notification settings - Fork 888
Improve the UI for the rules documentation #2275
Conversation
… each listed rule
This shows that CircleCI is still running the tests, but clicking through to the details shows that they all passed! perhaps this was related to the Amazon S3 outage yesterday? |
@nchen63 Hmm, that's odd, it's just a standard unicode symbol. Here's a test page for that symbol, does it render here? http://www.fileformat.info/info/unicode/char/1f6c8/browsertest.htm What about this one? This could be used instead and still have roughly the same meaning: http://www.fileformat.info/info/unicode/char/2139/browsertest.htm If not, I think this could be just fine without any icons at all. The icons would only be a good addition if they work cross browser, we don't want those squares showing up! |
@ChrisMBarr your first icon link doesn't work for me, but the second one does. I'm using OS X. |
@ChrisMBarr thanks! |
PR checklist
Overview of change:
This PR make some UI changes to the the list of rules, and the individual rule detail pages.
typescriptOnly
is truehasFix
is truerequiresTypeInfo
is trueHere's what the changes look like!
Eventually it would be really nice to have some interactive rule filters on that page. To be able to filter the rules list down to only show the rules that require type info, or could be auto-fixed would be awesome! I wanted to keep this PR minimal & focused though.