Don't call getPreEmitDiagnostics in tests #2769
Conversation
Diagnostics are ignored anyway and are not necessary for type checking
src/test.ts
Outdated
| @@ -84,6 +86,11 @@ export function runTest(testDirectory: string, rulesDirectory?: string | string[ | |||
| }; | |||
| compilerOptions = ts.parseJsonConfigFileContent(config, parseConfigHost, testDirectory).options; | |||
| } | |||
| // TODO remove in v6.0.0 | |||
| if (tslintConfig !== undefined && tslintConfig.linterOptions !== undefined && tslintConfig.linterOptions.typeCheck === true) { | |||
There was a problem hiding this comment.
linterOptions.typecheck was never public; we can remove it immediately. #1445 (comment)
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
an empty file looks pretty weird; can we at least make it extend some common tsconfig file? perhaps located at test/rules/test-tsconfig.json?
There was a problem hiding this comment.
I don't want to extend because that adds unnecessary overhead. I just added compilerOptions.module to have some config in the file.
Edit: target caused some problems, that's why I used module
|
Updated as suggested. Tests pass. Similar PR for Once this PR and #2762 are merged, I will refactor |
ghost
mentioned this pull request
PR checklist
Overview of change:
The diagnostics were ignored anyway and are not required for typechecking.
Creating a program and therefore enabling typechecked rules is now done when a tsconfig.json file is placed in the folder next to tslint.json.
That allows us to get rid of
linterOptions.typeCheckin tslint.json. It's still supported but deprecated in case someone used it in his tests.Is there anything you'd like reviewers to focus on?
This reduces the time needed to run the rule tests by 50%.
I'll also submit a PR that enables typechecked rules when passing
--project(without--type-check) on CLI. That will result in a 20% speedup when linting this project.CHANGELOG.md entry:
[develop] testing rules with type information is enabled when a
tsconfig.jsonis found next totslint.json