Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Enable typed rules with --project #2773

Merged
merged 3 commits into from
May 24, 2017
Merged

Enable typed rules with --project #2773

merged 3 commits into from
May 24, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented May 16, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

getPreEmitDiagnostics is not necessary to enable typed rules. This PR enables typed rules when --project is passed. --type-check now only checks for type errors in the project before doing the actual linting.
This reduces the time needed to lint this repo by around 17% with the current configuration.
Ref: #2769

Is there anything you'd like reviewers to focus on?

This may cause problems for users that pass --project and explicitly specify files that are not included in the project. Before the change these files were linted as if --project was not passed. After the change it throws an exception because the filename is not found in the program.
The latter seems to be the correct behavior. Though this may break some users.

This may also break users that have typed rules enabled but run tslint without --type-check.

CHANGELOG.md entry:

[enhancement] --project (or -p) enables rules that require the type checker. --type-check only checks for errors before linting is no longer required

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you take a pass at this @nchen63?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants