This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
getPreEmitDiagnostics
is not necessary to enable typed rules. This PR enables typed rules when--project
is passed.--type-check
now only checks for type errors in the project before doing the actual linting.This reduces the time needed to lint this repo by around 17% with the current configuration.
Ref: #2769
Is there anything you'd like reviewers to focus on?
This may cause problems for users that pass
--project
and explicitly specify files that are not included in the project. Before the change these files were linted as if--project
was not passed. After the change it throws an exception because the filename is not found in the program.The latter seems to be the correct behavior. Though this may break some users.
This may also break users that have typed rules enabled but run tslint without
--type-check
.CHANGELOG.md entry:
[enhancement]
--project
(or-p
) enables rules that require the type checker.--type-check
only checks for errors before linting is no longer required