Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Ignore .json files entirely to avoid errors due to tslint parsing json as typescript. #4001

Merged
merged 4 commits into from
Jan 10, 2019
Merged

Ignore .json files entirely to avoid errors due to tslint parsing json as typescript. #4001

merged 4 commits into from
Jan 10, 2019

Conversation

NaridaL
Copy link
Contributor

@NaridaL NaridaL commented Jun 29, 2018

Fixes #3957

PR checklist

Overview of change:

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] Skip linting of .json files to avoid problems with --resolveJsonModule compiler option

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 29, 2018

Not sure how to skip the test if TS doesn't support the flag.

Ignore .json files entirely to avoid errors due to tslint parsing json as typescript.
@GabrielDelepine

This comment has been minimized.

@adidahiya adidahiya self-assigned this Jan 10, 2019
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NaridaL, I updated your PR to only run the new test in TS 2.9+

@adidahiya adidahiya merged commit bb85d7d into palantir:master Jan 10, 2019
adidahiya pushed a commit that referenced this pull request Jan 10, 2019
This makes TSLint more friendly with the --resolveJsonModule compiler option.
ColCh added a commit to ColCh/tslint that referenced this pull request Feb 3, 2019
* master: (60 commits)
  Added tslint-brunch to the list of 3rd party tools (palantir#4251)
  Switch to tslint-plugin-prettier, clean up rule options config syntax (palantir#4488)
  Enable grouped-imports for ordered-imports rule in tslint:all config (palantir#4420)
  Ordered imports grouping (palantir#4134)
  trailing-comma: check for a closing parenthesis (palantir#4457)
  Update index.md (palantir#4473)
  [bugfix] `no-unsafe-any`: allow implicitly downcasting `any` to `unknown` (palantir#4442)
  Add v5.12.1 changelog
  Bump version to 5.12.1
  Fix quotemark avoid-template issues (palantir#4408)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  restrict increment-decrement fixer while fixing the postfix unary expressions (palantir#4415)
  Mention file names in script parse failures (palantir#4397)
  Revert breaking change to tslint:recommended, update tslint:latest (palantir#4404)
  Fix quotemark avoid-template issues (palantir#4408)
  Bump tslint dev dependency to 5.12.0 (palantir#4452)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  [README] Update link for Webstorm (palantir#4450)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tslint doesn't work well with ts 2.9 resolveJsonModule
4 participants