This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[bugfix] no-unsafe-any: allow implicitly downcasting any to unknown
#4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like simply ignoring the errors doesn't work here, unfortunately. |
|
Moving the tests containing |
JoshuaKGoldberg
approved these changes
Jan 8, 2019
|
The issue has been adressed, this PR is ready for a review when you have the time. |
adidahiya
reviewed
Jan 10, 2019
|
Thanks for the review! I have addressed your suggestions. I also removed the module imports as they didn't test anything that isn't tested by the other tests for this lint already. |
adidahiya
approved these changes
Jan 11, 2019
ColCh
added a commit
to ColCh/tslint
that referenced
this pull request
Feb 3, 2019
* master: (60 commits) Added tslint-brunch to the list of 3rd party tools (palantir#4251) Switch to tslint-plugin-prettier, clean up rule options config syntax (palantir#4488) Enable grouped-imports for ordered-imports rule in tslint:all config (palantir#4420) Ordered imports grouping (palantir#4134) trailing-comma: check for a closing parenthesis (palantir#4457) Update index.md (palantir#4473) [bugfix] `no-unsafe-any`: allow implicitly downcasting `any` to `unknown` (palantir#4442) Add v5.12.1 changelog Bump version to 5.12.1 Fix quotemark avoid-template issues (palantir#4408) Skip linting JSON files entirely (palantir#4001) Fix strict-type-predicate for unknown (palantir#4444) restrict increment-decrement fixer while fixing the postfix unary expressions (palantir#4415) Mention file names in script parse failures (palantir#4397) Revert breaking change to tslint:recommended, update tslint:latest (palantir#4404) Fix quotemark avoid-template issues (palantir#4408) Bump tslint dev dependency to 5.12.0 (palantir#4452) Skip linting JSON files entirely (palantir#4001) Fix strict-type-predicate for unknown (palantir#4444) [README] Update link for Webstorm (palantir#4450) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
unknown#4164Overview of change:
Downcasting
anytounknownis always safe. This PR fixes theno-unsafe-anyrule to reflect this.Is there anything you'd like reviewers to focus on?
I have copied from existing test cases and modified them to use
unknown. I have tried to be exhaustive, but there might still be false positives.CHANGELOG.md entry:
[bugfix]
no-unsafe-any: allow implicitly downcastinganytounknown