This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add object literal sort option to account for special characters #4193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The current behavior of the
object-literal-sort-keys
rule is to sort any accented characters after the non-accented "z" character, which is undesirable in accent-heavy languages like Spanish, French, and German. This change gives users of this rule the option to sort accented characters next to their non-accented counterpart.Is there anything you'd like reviewers to focus on?
localeCompare()
function is to make a "best fit" guess at which locale to use.Reference links:
CHANGELOG.md entry:
[new-rule-option]
object-literal-sort-keys
:locale-compare