Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix object-literal-sort-keys description #4241

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix object-literal-sort-keys description #4241

merged 1 commit into from
Nov 7, 2018

Conversation

stefanhamburger
Copy link
Contributor

@stefanhamburger stefanhamburger commented Oct 23, 2018

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Fixed the Markdown in the options description of the object-literal-sort-keys rule:

  • Indent text under the match-declaration-order option
  • Display code samples as code instead of raw text
  • Display config options in monospace text

There is an open pull request for this rule (#2831) but it is already lagging behind the master branch, so merging this PR won't interfere there. However, the PRs #3748 and #4193 will need to be updated.

CHANGELOG.md entry:

[no-log] [docs] Fix object-literal-sort-keys formatting

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 78f7bc2 into palantir:master Nov 7, 2018
@stefanhamburger stefanhamburger deleted the patch-1 branch November 7, 2018 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants