This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix callable-types should handle new(): T just like (): T
#4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
approved these changes
Dec 7, 2018
|
@giladgray Lint passing. Please see my newly added TODO item in |
JoshuaKGoldberg
suggested changes
Dec 11, 2018
|
@JoshuaKGoldberg An issue has been filed (#4364) and I've added a line above the TODO linking to the issue. |
JoshuaKGoldberg
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
new(): Tjust like(): T#4291Overview of change:
Walker for
callable-typesrule handles the case where an interface contains a single construct signature declaration.CHANGELOG.md entry:
[bugfix]
callable-typessupport interfaces containing a single construct signature (#4291)