Fix callable-types should handle new(): T just like (): T

src/language/formatter/formatter.ts

@@ -46,7 +46,12 @@ export interface IFormatterMetadata {
 
 export type ConsumerType = "human" | "machine";
 
+// See https://github.com/palantir/tslint/issues/4364
+// TODO: Enable the `callable-types` rule below. Currently, it
+// produces a lint error in several locations complaining about the
+// `no-inferred-empty-object-type` rule.
 export interface FormatterConstructor {
+    // tslint:disable-next-line:callable-types
     new (): IFormatter;
 }
 

src/rules/callableTypesRule.ts

@@ -18,6 +18,7 @@
 import {
     getChildOfKind,
     isCallSignatureDeclaration,
+    isConstructSignatureDeclaration,
     isIdentifier,
     isInterfaceDeclaration,
     isTypeLiteralNode,
@@ -58,7 +59,7 @@ function walk(ctx: Lint.WalkContext<void>) {
         ) {
             const member = node.members[0];
             if (
-                isCallSignatureDeclaration(member) &&
+                (isConstructSignatureDeclaration(member) || isCallSignatureDeclaration(member)) &&
                 // avoid bad parse
                 member.type !== undefined
             ) {
@@ -96,7 +97,7 @@ function noSupertype(node: ts.InterfaceDeclaration): boolean {
 }
 
 function renderSuggestion(
-    call: ts.CallSignatureDeclaration,
+    call: ts.CallSignatureDeclaration | ts.ConstructSignatureDeclaration,
     parent: ts.InterfaceDeclaration | ts.TypeLiteralNode,
     sourceFile: ts.SourceFile,
 ): string {

test/rules/callable-types/test.ts.fix

@@ -26,7 +26,9 @@ interface K {
 }
 
 // handle modifiers
-export type I = () => void;
+export type I0 = () => void;
+
+export type I1 = new () => void;
 
 export type T = () => void
 

test/rules/callable-types/test.ts.lint

@@ -54,9 +54,14 @@ interface K {
 }
 
 // handle modifiers
-export interface I {
+export interface I0 {
     (): void;
-    ~~~~~~~~~ [interface % ('type I = () => void;')]
+    ~~~~~~~~~ [interface % ('type I0 = () => void;')]
+}
+
+export interface I1 {
+    new (): void;
+    ~~~~~~~~~~~~~ [interface % ('type I1 = new () => void;')]
 }
 
 export type T = {