-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EA: fillna should accept same type #32414
Comments
@jbrockmendel Is this issue appropriate for first-time contributors? |
Probably not; it gets pretty deep into the weeds. #32402 might be a good fit if you're comfortable with cython, otherwise i suggest searching for the Good First Issue label |
I think this work on master. Could use a test
|
hey @mroeschke , Could you please tell on which cases should we really test it on? |
@Bhavay192 This entire code snippet should be tested |
Hey @mroeschke , thanks for replying. Soo according to you I should take different values of numpy arrays and test it on that?? |
The exact code snippet above should be written as a unit test and added to the testing suite: https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#writing-tests |
Hey @mroeschke, Since I'm quite new to open source and unit testing. Could you please help with in finding out what all test should I Perform on it?? |
Hey @mroeschke, I have written a small unit test for the above script. Now how will you review it please tell. Shall I send a PR?? Also please tell in which package shall I add my test into?? |
You can follow this guide to submit a PR and maintainers can help provide further guidance: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#contributing-your-changes-to-pandas |
removing milestone |
The text was updated successfully, but these errors were encountered: